[webkit-reviews] review granted: [Bug 78361] Selectively retrieve text content around a given position : [Attachment 133573] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 14:08:04 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 78361: Selectively retrieve text content around a given position
https://bugs.webkit.org/show_bug.cgi?id=78361

Attachment 133573: Patch
https://bugs.webkit.org/attachment.cgi?id=133573&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133573&action=review


> Source/WebCore/editing/TextIterator.cpp:1170
> +    // Prevent changing the iterator position if a form control element was
found and advance should stop on it.

This comment repeats what the code already says. Please remove.

> Source/WebCore/html/HTMLFormControlElement.cpp:468
> +    while (node) {

My preference is to use for-loop here.


More information about the webkit-reviews mailing list