[webkit-reviews] review granted: [Bug 81848] Show image diffs for gpu_tests on flakiness dashboard : [Attachment 133956] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dave Tu <dtu at chromium.org>'s request
for review:
Bug 81848: Show image diffs for gpu_tests on flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81848

Attachment 133956: Patch
https://bugs.webkit.org/attachment.cgi?id=133956&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133956&action=review


Please fix the nits and upload a new patch for the commit queue.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1846
> +	   } else {
> +	       html += ' | <b>Only shows actual results/diffs from the most
recent *failure* on each bot.</b>';
> +	   }

Single-line  else shouldn't have braces.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2197
> +	   } else {
> +	       container.replaceChild(item, dummyNode);
> +	   }

Single-line  else shouldn't have braces.