[webkit-reviews] review denied: [Bug 71207] An extra line break is inserted when pasting into a font element : [Attachment 134055] updated patch without using a help function

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 71207: An extra line break is inserted when pasting into a font element
https://bugs.webkit.org/show_bug.cgi?id=71207

Attachment 134055: updated patch without using a help function
https://bugs.webkit.org/attachment.cgi?id=134055&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134055&action=review


> Source/WebCore/editing/ReplaceSelectionCommand.cpp:127
> +	   if (pos.containerNode()->nonShadowBoundaryParentNode())
> +	       nextPosition = positionInParentAfterNode(pos.containerNode());

Again, this is incorrect. You need to skip siblings of pos.containerNode()
first.
I'd say that any solution that involves calling positionInParentAfterNode won't
be correct.
On my second thought, we should be able to replace this enture function by
pos.downstream().