[webkit-reviews] review denied: [Bug 82350] [BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer : [Attachment 134092] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Andrew Lo <anlo at rim.com>'s request for
review:
Bug 82350: [BlackBerry] Switch WebPageCompositor to use
AnimationFrameRateController instead of timer
https://bugs.webkit.org/show_bug.cgi?id=82350

Attachment 134092: Patch
https://bugs.webkit.org/attachment.cgi?id=134092&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134092&action=review


Looks good, some prefixes can be stripped.

> Source/WebKit/blackberry/Api/WebPageCompositor.cpp:53
> +   
BlackBerry::Platform::AnimationFrameRateController::instance()->removeClient(th
is);

No BlackBerry prefix needed.

> Source/WebKit/blackberry/Api/WebPageCompositor.cpp:130
> +	      
BlackBerry::Platform::AnimationFrameRateController::instance()->addClient(this)
;

Ditto.

> Source/WebKit/blackberry/Api/WebPageCompositor_p.h:44
> +class WebPageCompositorPrivate : public
RefCounted<WebPageCompositorPrivate>, public
BlackBerry::Platform::AnimationFrameRateClient {

Ditto.