[webkit-reviews] review granted: [Bug 82310] Handle DRT crash caused by Android OOM. : [Attachment 134009] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 27 10:09:23 PDT 2012
Tony Chang <tony at chromium.org> has granted Hao Zheng <zhenghao at chromium.org>'s
request for review:
Bug 82310: Handle DRT crash caused by Android OOM.
https://bugs.webkit.org/show_bug.cgi?id=82310
Attachment 134009: Patch
https://bugs.webkit.org/attachment.cgi?id=134009&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134009&action=review
Should there be test cases for this?
> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:551
> + return None if (return_match is None) else
int(return_match.group(1))
Nit: This could be "return return_match and int(return_match.group(1))".
More information about the webkit-reviews
mailing list