[webkit-reviews] review granted: [Bug 82056] Use enumeration for CSS parser mode : [Attachment 133857] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 82056: Use enumeration for CSS parser mode
https://bugs.webkit.org/show_bug.cgi?id=82056

Attachment 133857: Patch
https://bugs.webkit.org/attachment.cgi?id=133857&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=133857&action=review


> Source/WebCore/css/CSSGrammar.y:1026
> -	   if (!p->m_strict)
> +	   if (p->m_cssParserMode != CSSStrictMode)

It would be better to be explicit and write these in terms of modes that do get
this behavior.