[webkit-reviews] review granted: [Bug 17450] in page anchor and keyboard navigation : [Attachment 131012] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 17450: in page anchor and keyboard navigation
https://bugs.webkit.org/show_bug.cgi?id=17450

Attachment 131012: Patch
https://bugs.webkit.org/attachment.cgi?id=131012&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131012&action=review


r=me with fixes suggested

> Source/WebCore/accessibility/AXObjectCache.cpp:164
> +    Document* document = node->document();

you probably want to ASSERT(node)

> Source/WebCore/accessibility/AXObjectCache.cpp:173
> +    if (!selection)

it seems that even if selection == 0, we can still set the focusedNode on the
document