[webkit-reviews] review requested: [Bug 52810] [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode : [Attachment 134069] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 08:17:06 PDT 2012


Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 52810: [Qt] Couple of tests have different results on 64 bit and/or in
debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

Attachment 134069: proposed patch
https://bugs.webkit.org/attachment.cgi?id=134069&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
I think we should use similar fix to GTK and Chromium guys:
http://trac.webkit.org/changeset/103040/trunk/Tools/Scripts/webkitdirs.pm

I don't think if we should support older architecture than P4.

After this patch and rebasing now skipped tests related to this bug,
we can unskip ~70 tests, only 5 tests will remain with rounding issues.


More information about the webkit-reviews mailing list