[webkit-reviews] review granted: [Bug 82341] [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests : [Attachment 134065] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 08:15:26 PDT 2012


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 82341: [GTK] Add --skipped command line option to
Tools/Scripts/run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=82341

Attachment 134065: Patch
https://bugs.webkit.org/attachment.cgi?id=134065&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review


> Tools/Scripts/run-gtk-tests:216
> +	   # By default skipped test are skipped,
> +	   # run them only when there are specific
> +	   # test cases failing.

Super nit: This comment could probably be one line.

> Tools/Scripts/run-gtk-tests:296
> +				help='Specifies how to treat the Skipped
tests')

Nit: Skipped -> skipped


More information about the webkit-reviews mailing list