[webkit-reviews] review requested: [Bug 78491] [GTK] Implement WebUIClient's runOpenPanel in WebKit2GTK+ : [Attachment 134053] Patch Proposal + Unit Tests + Docs

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 78491: [GTK] Implement WebUIClient's runOpenPanel in WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=78491

Attachment 134053: Patch Proposal + Unit Tests + Docs
https://bugs.webkit.org/attachment.cgi?id=134053&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
After some time has passed, and in order to help moving things forward I'm now
attaching a new patch with the following changes:

* Renamed functions to follow the second one of Martin's suggestions in comment
#58, which I think Carlos is also in favor of right now (so do I):
     webkit_file_chooser_request_select_files
     webkit_file_chooser_request_get_previously_selected_files

* Renamed executeMouseButtonEvent to doMouseButtonEvent, as per Carlos's
suggestion in comment #61 (it's a private function anyway)

* Patch rebased against the SVN trunk, which also meant that changes in good
ol' JavascriptCore/wtf are now in WTF/wtf.

Hope this helps on easing the review :-)