[webkit-reviews] review granted: [Bug 82322] Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before. : [Attachment 134028] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 82322: Web Inspector: startEditing should remove tabIndex attribute from
the element if it was not set before.
https://bugs.webkit.org/show_bug.cgi?id=82322

Attachment 134028: Patch
https://bugs.webkit.org/attachment.cgi?id=134028&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134028&action=review


> Source/WebCore/inspector/front-end/UIUtils.js:284
> +    if (typeof(oldTabIndex) !== "number" || oldTabIndex < 0)

typeof oldTabIndex !== "number" or use isNaN.