[webkit-reviews] review requested: [Bug 81883] [WK2] Add style support for WebPopUpItem : [Attachment 134011] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 27 04:53:42 PDT 2012
Antaryami Pandia <antaryami.pandia at motorola.com> has asked for review:
Bug 81883: [WK2] Add style support for WebPopUpItem
https://bugs.webkit.org/show_bug.cgi?id=81883
Attachment 134011: Patch.
https://bugs.webkit.org/attachment.cgi?id=134011&action=review
------- Additional Comments from Antaryami Pandia
<antaryami.pandia at motorola.com>
Mac throws below compilation error:-
WebPopupMenuProxyMac.mm:73: error: 'const struct WebKit::WebPopupItem' has no
member named 'm_textDirection'
WebPopupMenuProxyMac.mm:80: error: 'const struct WebKit::WebPopupItem' has no
member named 'm_hasTextDirectionOverride'
I will resolve these errors in a new patch along with review comments provided
by you.
Marking the "r?", to get review comments.
More information about the webkit-reviews
mailing list