[webkit-reviews] review granted: [Bug 82318] Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode. : [Attachment 134015] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 04:17:20 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 82318: Web Inspector: dispatch breakpoint-added and breakpoint-removed
events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82318

Attachment 134015: Patch
https://bugs.webkit.org/attachment.cgi?id=134015&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134015&action=review


> Source/WebCore/inspector/front-end/ScriptsPanel.js:285
> +    _addBreakpointListeners: function(uiSourceCode)

Please add type annotations.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:291
> +    _removeBreakpointListeners: function(uiSourceCode)

ditto


More information about the webkit-reviews mailing list