[webkit-reviews] review granted: [Bug 82310] Handle DRT crash caused by Android OOM. : [Attachment 134003] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 27 02:24:33 PDT 2012
Adam Barth <abarth at webkit.org> has granted Hao Zheng <zhenghao at chromium.org>'s
request for review:
Bug 82310: Handle DRT crash caused by Android OOM.
https://bugs.webkit.org/show_bug.cgi?id=82310
Attachment 134003: Patch
https://bugs.webkit.org/attachment.cgi?id=134003&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134003&action=review
Ok.
>>> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:580
>>> + error.append(line)
>>
>> I'm not sure I quite understand what these lines do. Can you explain a bit
more?
>
> Sure. This is to append the last output line when crash happens.
I see. Previously we were truncating.
More information about the webkit-reviews
mailing list