[webkit-reviews] review granted: [Bug 82275] WebGL content swapped at wrong time in threaded compositing mode : [Attachment 133947] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 82275: WebGL content swapped at wrong time in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82275

Attachment 133947: Patch
https://bugs.webkit.org/attachment.cgi?id=133947&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133947&action=review


Looks good overall. One minor comment. The Mac build failure is probably a
minor issue. r=me

> Source/WebCore/platform/graphics/gpu/DrawingBuffer.h:58
> +    static PassRefPtr<DrawingBuffer> create(GraphicsContext3D*, const
IntSize&, bool seperateBackingTexture, bool alpha);

Typo: seperateBackingTexture -> separateBackingTexture. Should we define an
enum instead of adding another anonymous bool argument to the constructor?
Perhaps also retrofit the separateBackingTexture argument with one?