[webkit-reviews] review granted: [Bug 82267] Build system prep work for upstreaming iOS changes : [Attachment 133934] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 82267: Build system prep work for upstreaming iOS changes
https://bugs.webkit.org/show_bug.cgi?id=82267

Attachment 133934: Patch
https://bugs.webkit.org/attachment.cgi?id=133934&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133934&action=review


r=me

> Source/WebCore/ChangeLog:10
> +	   (applyPreprocessor): Add local @args variable.

An explanation of the benefit of this @args variable wouldn't hurt.

> Source/WebCore/bindings/scripts/preprocessor.pm:55
> +	   $preprocessor = $gccLocation;
> +	   push(@args, qw(-E -P -x c++));

It seems like the $gccLocation variable is now redundant.