[webkit-reviews] review granted: [Bug 81740] [chromium] Transfer wheel fling via WebCompositorInputHandlerClient : [Attachment 133913] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 81740: [chromium] Transfer wheel fling via WebCompositorInputHandlerClient
https://bugs.webkit.org/show_bug.cgi?id=81740

Attachment 133913: Patch
https://bugs.webkit.org/attachment.cgi?id=133913&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133913&action=review


The WebKit side looks good to me.  A few minor comments:

> Source/WebCore/platform/ActivePlatformGestureAnimation.cpp:73
> +{
> +}

Can you put a trace event here, like the other constructor?

> Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:397
> +    // *) cumulativeScroll depends on the curve, but since we've animated in
the -X direction the X value should be < 0

These sign flips are all really hard to follow.  The delta being positive means
animating in the negative direction, and the X value being < 0 means the
cumulative scroll is > 0.  Is there any way to make these comments or variable
names more readable?