[webkit-reviews] review granted: [Bug 82250] Allow expectations on directories in virtual test suites : [Attachment 133915] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 82250: Allow expectations on directories in virtual test suites
https://bugs.webkit.org/show_bug.cgi?id=82250

Attachment 133915: Patch
https://bugs.webkit.org/attachment.cgi?id=133915&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133915&action=review


> Tools/Scripts/webkitpy/layout_tests/port/base.py:1099
> +		   return test_name.replace(suite.name, suite.base)

Your change will allow lookup_virtual_test_base() to handle paths that don't
actually map onto base paths that exist. I had to convince myself that that was
okay, but I think I did. 

Given that, I don't think you even need to do the get() on line 1096. You can
just replace line 1096 with your 1099.