[webkit-reviews] review granted: [Bug 82182] Revert linesBoundingBox to integers : [Attachment 133763] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 82182: Revert linesBoundingBox to integers
https://bugs.webkit.org/show_bug.cgi?id=82182

Attachment 133763: Patch
https://bugs.webkit.org/attachment.cgi?id=133763&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133763&action=review


> Source/WebCore/ChangeLog:12
> +	   LayoutRects are intended to be pixel snapped to determine the
ultimate screen
> +	   coordinates, but the Inline Box tree is laid out using floats, and
pixel snapping
> +	   the resulting box from linesBoundingBox would produce a potentially
incorrect
> +	   rectangle. Keeping this using enclosingIntRect retains the previous
accuracy and
> +	   prevents misuse.

Clearly you've learned a lot as youv'e gone.  I hope that we've documented this
learning for others.  To help make it obvious where LayoutPoint vs. IntPoitn
vs. FloatPoint should be used.	It's still not always 100% obvious to me. :(