[webkit-reviews] review granted: [Bug 81921] Update usage of LayoutUnits in RenderListMarker : [Attachment 133476] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 81921: Update usage of LayoutUnits in RenderListMarker
https://bugs.webkit.org/show_bug.cgi?id=81921

Attachment 133476: Patch
https://bugs.webkit.org/attachment.cgi?id=133476&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133476&action=review


OK.

> Source/WebCore/rendering/RenderListMarker.cpp:1124
> +    marker.moveBy(roundedIntPoint(boxOrigin));

I thought we had new fancy .round() methods?

> Source/WebCore/rendering/RenderListMarker.cpp:1263
> +	   marker.moveBy(IntPoint(roundToInt(box.x()), roundToInt(box.y() -
logicalHeight())));

making a LayoutPoint and rounding that seems easier...