[webkit-reviews] review requested: [Bug 79080] Row and column headers not exposed by WebCore accessibility : [Attachment 133905] 1) Address review comments, 2) Do work to determine cell role only once, 3) Separate/clarify tests and provided -expected files for Chromium-win port

[bugzilla-daemon at webkit.org]

Aaron Leventhal <aaronlevbugs at gmail.com> has asked  for review:
Bug 79080: Row and column headers not exposed by WebCore accessibility
https://bugs.webkit.org/show_bug.cgi?id=79080

Attachment 133905: 1) Address review comments, 2) Do work to determine cell
role only once, 3) Separate/clarify tests and provided -expected files for
Chromium-win port
https://bugs.webkit.org/attachment.cgi?id=133905&action=review

------- Additional Comments from Aaron Leventhal <aaronlevbugs at gmail.com>
I'm having a bit of trouble using uploat-webkit-patch and prepare-changeLog
from Windows, so for now here are the comments inline.

Ensure that the table header roles (row/column) are exposed correctly. Neither
IAccessible2 nor ATK/AT-SPI use something like
AXColumnHeaderUIElements/AXRowHeaderUIElements ... Windows/Linux ATs expect the
role to provide this information.

At first I tried to use the results of
AccessibilityTable[Row|Column]->headerObject() but given that the role needed
to be const I ran into dependency issues getting the information at cell
construction time. For bug 81681 (multiple row/column headers per cell) it
might make sense to reuse the information from the role calculation for
AXColumnHeaderUIElements and AXRowHeaderUIElements.