[webkit-reviews] review denied: [Bug 45228] window.scrollBy() scrolls incorrectly when zoomed in/out : [Attachment 133901] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Eugene Girard
<girard at chromium.org>'s request for review:
Bug 45228: window.scrollBy() scrolls incorrectly when zoomed in/out
https://bugs.webkit.org/show_bug.cgi?id=45228

Attachment 133901: Patch
https://bugs.webkit.org/attachment.cgi?id=133901&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133901&action=review


> Source/WebCore/page/DOMWindow.cpp:1353
> -    view->scrollBy(IntSize(x, y));
> +    IntPoint layoutPos(view->mapFromCSSToLayoutUnits(x),
view->mapFromCSSToLayoutUnits(y));
> +    view->setScrollPosition(layoutPos);

This seems wrong. x,y is a delta, but you're using it as an absolute offset.