[webkit-reviews] review granted: [Bug 82247] Find in page overlay and bouncy are not always positioned correctly : [Attachment 133894] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 26 14:37:12 PDT 2012
Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 82247: Find in page overlay and bouncy are not always positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=82247
Attachment 133894: Patch
https://bugs.webkit.org/attachment.cgi?id=133894&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review
> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227
> + // Assume that we'll be successful in updating the scroll position.
> + updateMainFrameScrollPosition(scrollPosition);
Can you explain what happens if that assumption doesn't hold, and how we deal
with it?
More information about the webkit-reviews
mailing list