[webkit-reviews] review granted: [Bug 81812] garden-o-matic should special case reftests : [Attachment 133890] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 81812: garden-o-matic should special case reftests
https://bugs.webkit.org/show_bug.cgi?id=81812

Attachment 133890: Patch
https://bugs.webkit.org/attachment.cgi?id=133890&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133890&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/results.js:177
> +    for (var builder in results) {

We've been using forEach rather than loops.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/results.js:203
> +		   $(header).append('<div class="non-action-button">Reftest
cannot be rebaselined</div>');

What is the gardener supposed to do in this case?  Can we provide some help
text?