[webkit-reviews] review granted: [Bug 82158] add a Tree abstraction to test-webkitpy to better encapsulate things : [Attachment 133713] fix typos

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 26 14:15:30 PDT 2012


Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 82158: add a Tree abstraction to test-webkitpy to better encapsulate things
https://bugs.webkit.org/show_bug.cgi?id=82158

Attachment 133713: fix typos
https://bugs.webkit.org/attachment.cgi?id=133713&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'd rename _Tree to something more specific (and maybe put it at the top of the
file?).  There's an argument that says we should put the new class in its own
module, which would have the benefit of making test-webkitpy smaller.  If we
did that we, we'd probably want to use filesystem rather than os.path.	I think
it's a question of how far you'd like to shave this yak.


More information about the webkit-reviews mailing list