[webkit-reviews] review granted: [Bug 82112] nrwt: remove --worker-model flag : [Attachment 133609] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 26 14:12:04 PDT 2012
Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 82112: nrwt: remove --worker-model flag
https://bugs.webkit.org/show_bug.cgi?id=82112
Attachment 133609: Patch
https://bugs.webkit.org/attachment.cgi?id=133609&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133609&action=review
I like that this patch deletes a bunch of code. I'm slightly worried about
overloading the semantics of --child-processes, but I don't think that's a big
deal.
> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:790
> +
This change seems spurious.
More information about the webkit-reviews
mailing list