[webkit-reviews] review denied: [Bug 82233] Retry crashing tests serially at the end of NRWT on Apple Mac : [Attachment 133873] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 82233: Retry crashing tests serially at the end of NRWT on Apple Mac
https://bugs.webkit.org/show_bug.cgi?id=82233

Attachment 133873: Patch
https://bugs.webkit.org/attachment.cgi?id=133873&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
Note that the tests that are retried are still actually run concurrently, so
this patch may not do what you think it should do. 

I'm sure I had a patch at one point that did run things serially, but I guess I
never committed it; it would be easy to make that change and I can't really
think of a good reason not to do it, so you could either add that to this or
add a separate patch to do so, if you like, or you could file a bug and I could
do it at some point.

All that aside, I'm a bit torn by this patch. I can see the argument in
retrying the crashes to see if they're consistently crashing or just flaky
under load; I don't really have a problem with that. 

However, I'm not sure that i think a flaky crash should be ignored (which is
what would happen by default).

Is it hard (or impossible) to fix things so that DRT and WTR don't actually
crash?

As an actual comment on the crash, I think I would prefer this to be a method
on the port itself (like port.should_retry_crashes()), rather than a test
against the port name.