[webkit-reviews] review granted: [Bug 23166] background-clip doesn't work when border-radius is specified : [Attachment 133746] proposed fix for border-radius background clipping even with non-renderable radii

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Vlad Grecescu
<igrecesc at adobe.com>'s request for review:
Bug 23166: background-clip doesn't work when border-radius is specified
https://bugs.webkit.org/show_bug.cgi?id=23166

Attachment 133746: proposed fix for border-radius background clipping even with
non-renderable radii
https://bugs.webkit.org/attachment.cgi?id=133746&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133746&action=review


> LayoutTests/fast/css/background-clip-radius-values.html:7
> +    border-radius: 10px 30px;

Please make the radii larger to make potential test failures more obvious.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:637
> +void RenderBoxModelObject::clipComplexRoundedRect(GraphicsContext * context,
const LayoutRect& rect, const RoundedRect& clipRect)

GraphicsContext* context

It's not really clear what "complex" means in the method name.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:641
> +    // For non-renderable rounded rectangles there are only two opposing
non-zero radii
> +    // (if they are computed from renderable outer border rounded
rectangles)

I don't really understand this comment. Can you make it clearer?