[webkit-reviews] review granted: [Bug 82142] Add a notification function for detaching to TextFieldDecorator : [Attachment 133676] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 26 09:11:58 PDT 2012
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 82142: Add a notification function for detaching to TextFieldDecorator
https://bugs.webkit.org/show_bug.cgi?id=82142
Attachment 133676: Patch
https://bugs.webkit.org/attachment.cgi?id=133676&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review
ok.
> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68
> +inline HTMLInputElement* TextFieldDecorationElement::hostInput()
> +{
> + ASSERT(shadowAncestorNode());
> + ASSERT(shadowAncestorNode()->hasTagName(inputTag));
> + return static_cast<HTMLInputElement*>(shadowAncestorNode());
> +}
We usually put these into the header, right?
More information about the webkit-reviews
mailing list