[webkit-reviews] review granted: [Bug 79477] [GTK] Add resources API to WebKit2 GTK+ : [Attachment 132090] Updated patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 79477: [GTK] Add resources API to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=79477

Attachment 132090: Updated patch
https://bugs.webkit.org/attachment.cgi?id=132090&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132090&action=review


Looks good to me!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebResource.cpp:263
> + *	is emitted again with a redirected response, the active URI is the
> + *	redirected URI.

"the active URI is the URI the request was redirected to" sounds better I think


> Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp:300
> +    // No cached resurce: First load.

s/resurce/resource/ (and a few more after this)