[webkit-reviews] review granted: [Bug 81589] [Qt][WK2] Support multi-file upload : [Attachment 132715] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 81589: [Qt][WK2] Support multi-file upload
https://bugs.webkit.org/show_bug.cgi?id=81589

Attachment 132715: Patch
https://bugs.webkit.org/attachment.cgi?id=132715&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132715&action=review


r=me, but please fix the conversion before landing

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:384
> +    if (!dialogRunner.initForFilePicker(filePicker, q, selectedFileNames,
type))

Hmm, initForFilePicker's last argument is a boolean, but type is an enum. It
sounds like that conversion should be a bit more explicit, because like this
it's not very readable.