[webkit-reviews] review denied: [Bug 82042] Unavailable pre-processor macro in non-Qt environments : [Attachment 133487] Patch proposal to fix missing symbols in non-Qt environments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 26 06:26:52 PDT 2012


Simon Hausmann <hausmann at webkit.org> has denied Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 82042: Unavailable pre-processor macro in non-Qt environments
https://bugs.webkit.org/show_bug.cgi?id=82042

Attachment 133487: Patch proposal to fix missing symbols in non-Qt environments
https://bugs.webkit.org/attachment.cgi?id=133487&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'd prefer if this was written without QT_VERSION_CHECK instead of introducing
_QT5, i.e.:

#if PLATFORM(QT) && QT_VERSION >= 0x050000


More information about the webkit-reviews mailing list