[webkit-reviews] review canceled: [Bug 75553] [GTK][WK2] Initial FullScreen support : [Attachment 132293] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 26 01:52:07 PDT 2012


Philippe Normand <pnormand at igalia.com> has canceled Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 75553: [GTK][WK2] Initial FullScreen support
https://bugs.webkit.org/show_bug.cgi?id=75553

Attachment 132293: Patch
https://bugs.webkit.org/attachment.cgi?id=132293&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132293&action=review


>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:606
>> +#endif
> 
> Override key_press_event instead of connecting a callback and return early in
the view is not running fullscreen

Do you mean move that code to webkitWebViewBaseKeyPressEvent?


More information about the webkit-reviews mailing list