[webkit-reviews] review denied: [Bug 81977] WebKitWebView signals with GError parameters cause crashes when using GObject Introspection : [Attachment 133364] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Gary Kramlich
<grim at reaperworld.com>'s request for review:
Bug 81977: WebKitWebView signals with GError parameters cause crashes when
using GObject Introspection
https://bugs.webkit.org/show_bug.cgi?id=81977

Attachment 133364: Patch
https://bugs.webkit.org/attachment.cgi?id=133364&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133364&action=review


> Source/WebKit/gtk/ChangeLog:5
> +	   Added marshallers for BOOLEAN:OBJECT,STRING,BOXED and
VOID:OBJECT,OBJECT,BOXED and changed the signal signatures for
WebKitWebView::load-fail and WebKitWebView::resource-load-failed to use the new
marshallers since GError has been a GBoxed type since Gtk 2.26.  This fixes
these signals for the gobject-introspection bindings.
> +	   https://bugs.webkit.org/show_bug.cgi?id=81977
> +

I really appreciate you including a ChangeLog for this change. In the future,
it's better to generate the ChangeLog with Tools/Scripts/prepare-ChangeLogs and
to put the long-form description below the "Revied by..." line.