[webkit-reviews] review granted: [Bug 81802] REGRESSION (r110065-r110080): fast/forms/placeholder-set-attribute.html is failing intermittently because WebKit fails to repaint after setting the placeholder attribute : [Attachment 133687] Proposed fix. Unfortunately no new test.

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Julien Chaffraix <jchaffraix at webkit.org>'s request
for review:
Bug 81802: REGRESSION (r110065-r110080):
fast/forms/placeholder-set-attribute.html is failing intermittently because
WebKit fails to repaint after setting the placeholder attribute
https://bugs.webkit.org/show_bug.cgi?id=81802

Attachment 133687: Proposed fix. Unfortunately no new test.
https://bugs.webkit.org/attachment.cgi?id=133687&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=133687&action=review


r=me if you correct the style

> Source/WebCore/ChangeLog:11
> +	   REGRESSION (r110065-r110080):
fast/forms/placeholder-set-attribute.html is failing intermittently because
WebKit fails to repaint after setting the placeholder attribute
> +	   https://bugs.webkit.org/show_bug.cgi?id=81802
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Covered by fast/forms/placeholder-set-attribute.html which should be
less flaky.
> +
> +	   Unfortunately no new test case as this bug requires a very specific
set of conditions that I couldn't reproduce deterministically.
> +

Can you explain how the change (presumably r110072) caused this regression?

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:297
> +	   if (!placeholderBoxHadLayout &&
placeholderBox->checkForRepaintDuringLayout())
> +	       // This assumes a shadow tree without floats. If floats are
added, the
> +	       // logic should be shared with RenderBlock::layoutBlockChild.
> +	       placeholderBox->repaint();

This multi-line clause needs to be in braces.