[webkit-reviews] review requested: [Bug 82107] [chromium] When prepainting fails, tiles dirty rects may be cleared : [Attachment 133619] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 22:12:49 PDT 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 82107: [chromium] When prepainting fails, tiles dirty rects may be cleared
https://bugs.webkit.org/show_bug.cgi?id=82107

Attachment 133619: Patch
https://bugs.webkit.org/attachment.cgi?id=133619&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Using using.

I like having separate checks for hasTileAt() and hasTextureForTileAt(). It
lets me check FALSE of the hasTileAt() separately so I can know that I didn't
push a dirty texture (I noticed that we were in this situation because of this
unit test).


More information about the webkit-reviews mailing list