[webkit-reviews] review granted: [Bug 73846] clean up NRWT logging/metering, be less verbose : [Attachment 133592] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 73846: clean up NRWT logging/metering, be less verbose
https://bugs.webkit.org/show_bug.cgi?id=73846

Attachment 133592: Patch
https://bugs.webkit.org/attachment.cgi?id=133592&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133592&action=review


Feel free to ignore any of these suggestions.

> Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py:50
> +    def _newline(txt):

Nit: i'd call this _ensure_newline

> Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py:63
> +	   self._progress_delay_in_secs = 0.033 if self._erasing else 10.0

Nit: I think something like 0.1 would be fine here. Noone will notice the
difference.

> Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py:76
> +	   """Restore / clean up any changes to the logging configuration."""

Here and below, these function comments describe the obvious "what" the
function does. I don't think they are useful.

> Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py:81
> +    def progress(self, txt):

s/progress/write_progress?

> Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py:87
> +    def update(self, txt, now=None):

s/update/write_overwritable?