[webkit-reviews] review denied: [Bug 82111] [chromium] RootLayer was not being checked for null causing segfaults very rarely. : [Attachment 133605] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Michal Mocny
<mmocny at chromium.org>'s request for review:
Bug 82111: [chromium] RootLayer was not being checked for null causing
segfaults very rarely.
https://bugs.webkit.org/show_bug.cgi?id=82111

Attachment 133605: Patch
https://bugs.webkit.org/attachment.cgi?id=133605&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133605&action=review


> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:407
> -    m_defaultRenderSurface = rootLayer()->renderSurface();
> +    m_defaultRenderSurface = rootLayer() ? rootLayer()->renderSurface() : 0;


This isn't enough.  If m_defaultRenderSurface is 0, you'll deref 0 in
useRenderSurface.  Can you please assert on rootLayer() here and early out in
CCLTHI::drawLayers if there is no root layer?