[webkit-reviews] review granted: [Bug 82106] [chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found. : [Attachment 133604] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 82106: [chromium] CCLayerTreeHostImpl::scrollBegin() should return
ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.
https://bugs.webkit.org/show_bug.cgi?id=82106

Attachment 133604: Patch
https://bugs.webkit.org/attachment.cgi?id=133604&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133604&action=review


Thanks for the quick fix.  R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:596
> -    if (type == CCInputHandlerClient::Wheel &&
m_scrollLayerImpl->haveWheelEventHandlers()) {
> +    if ((type == CCInputHandlerClient::Wheel || type ==
CCInputHandlerClient::Gesture) && m_scrollLayerImpl->haveWheelEventHandlers())
{

I think this is not going to be true once when we have touch flings, but we can
burn that bridge when we come to it.