[webkit-reviews] review denied: [Bug 82089] Match DOM4 spec with respect to DocumentFragment insertion : [Attachment 133570] Patch minus replaceChild ordering change

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Adam Klein <adamk at chromium.org>'s
request for review:
Bug 82089: Match DOM4 spec with respect to DocumentFragment insertion
https://bugs.webkit.org/show_bug.cgi?id=82089

Attachment 133570: Patch minus replaceChild ordering change
https://bugs.webkit.org/attachment.cgi?id=133570&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133570&action=review


> Source/WebCore/dom/ContainerNode.cpp:287
> +    if (next && (next->previousSibling() == newChild || next == newChild))
// nothing to do

What if next had been removed from this during the mutation event? r- because
of this.

In general, it's better to define a boolean or a helper function that documents
this than adding a comment like "nothing to do",