[webkit-reviews] review denied: [Bug 80531] REGRESSION(r110072): fast/forms/textfield-overflow.html is failing : [Attachment 133489] Same as previously but added a progression, the EWS should be happy now

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 14:55:16 PDT 2012


Ojan Vafai <ojan at chromium.org> has denied  review:
Bug 80531: REGRESSION(r110072): fast/forms/textfield-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=80531

Attachment 133489: Same as previously but added a progression, the EWS should
be happy now
https://bugs.webkit.org/attachment.cgi?id=133489&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
This looks to me like a vertical-writing-mode bug. I think the problem here is
that RenderTextControlSingleLine::layout is mixing logical and physical values.
It should only deal with logical values. If you s/height/logicalHeight and
s/width/logicalWidth everywhere in this function, does that fix the bug?


More information about the webkit-reviews mailing list