[webkit-reviews] review granted: [Bug 80030] [GObject bindings] Supplemental interfaces are not disabled with the "Conditional" attribute : [Attachment 133536] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 80030: [GObject bindings] Supplemental interfaces are not disabled with the
"Conditional" attribute
https://bugs.webkit.org/show_bug.cgi?id=80030

Attachment 133536: Patch
https://bugs.webkit.org/attachment.cgi?id=133536&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133536&action=review


I'll land this one.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:117
> +sub HumanReadableConditional {

HumanReadableConditional -> humanReadbleConditional?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:362
> +sub GenerateConditionalWarn

GenerateConditionalWarn -> generateConditionalWarning

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:368
> +    if ($conditional) {

This probably deserves an early return.