[webkit-reviews] review granted: [Bug 82073] [GTK] libgcrypt and p11-kit should not be in jhbuild modules : [Attachment 133542] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 82073: [GTK] libgcrypt and p11-kit should not be in jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82073

Attachment 133542: Patch
https://bugs.webkit.org/attachment.cgi?id=133542&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133542&action=review


Looks good, though if possible it'd would be nice to remove
Tools/gtk/clean-jhbuild and replace it with a couple inline Perl system()
calls.

> Tools/Scripts/webkitdirs.pm:1947
> +	   # If the configuration changed, dependencies may have been removed.
> +	   # Since we lack a granular way of uninstalling those we wipe out the

> +	   # jhbuild root and start from scratch.
> +	   if (system("$sourceDir/Tools/gtk/clean-jhbuild") ne 0) {
> +	       die "Cleaning jhbuild failed!";
> +	   }

Is it possible to do this in Perl rather than creating another script?

> Tools/Scripts/webkitdirs.pm:1953
> +    if (checkForArgumentAndRemoveFromArrayRef("--update-gtk", \@buildArgs))
{
> +	   $needUpdate = 1;
> +    }

This argument is unfamiliar to me. Where is it used?