[webkit-reviews] review denied: [Bug 82081] [SOUP] Implement WebFrameNetworkingContext for soup in WebKit2 : [Attachment 133543] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 82081: [SOUP] Implement WebFrameNetworkingContext for soup in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=82081

Attachment 133543: Patch
https://bugs.webkit.org/attachment.cgi?id=133543&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133543&action=review


>
Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:29
> +
> +#include <WebCore/ResourceHandle.h>

Extra newline here.

>
Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:38
> +SoupSession* WebFrameNetworkingContext::soupSession() const
> +{
> +    return ResourceHandle::defaultSession();
> +}

This seems unused. I would prefer adding this when it's first used instead of
introducing dead code now.