[webkit-reviews] review granted: [Bug 78361] Selectively retrieve text content around a given position : [Attachment 133537] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 23 12:57:21 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 78361: Selectively retrieve text content around a given position
https://bugs.webkit.org/show_bug.cgi?id=78361
Attachment 133537: Patch
https://bugs.webkit.org/attachment.cgi?id=133537&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133537&action=review
> Source/WebCore/editing/TextIterator.cpp:243
> +static bool enclosedByFormControlElement(Node* node)
Nit: enclosingFormControlElement. You may consider moving this to
FromControlElement.h/cpp after changing the return type to Node*.
More information about the webkit-reviews
mailing list