[webkit-reviews] review denied: [Bug 82056] Use enumeration for CSS parser mode : [Attachment 133516] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 23 12:12:10 PDT 2012
Antti Koivisto <koivisto at iki.fi> has denied review:
Bug 82056: Use enumeration for CSS parser mode
https://bugs.webkit.org/show_bug.cgi?id=82056
Attachment 133516: Patch
https://bugs.webkit.org/attachment.cgi?id=133516&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=133516&action=review
r- for clarification.
> Source/WebCore/css/CSSParser.h:288
> + CSSParserMode m_cssParserMode;
Since CSSParserMode now defines a mask of bits, it doesn't make sense to use it
as the type for the field. Enum field should have values defined by the enum
only.
> Source/WebCore/css/CSSParserMode.h:38
> +enum CSSParserMode {
> + CSSQuirksMode = 0x1,
> + CSSStrictMode = 0x2,
> + // SVG should always be in strict mode. For SVG attributes, the rules
differ to strict sometimes.
> + SVGAttributeMode = 0x4
> +};
I thought we would have three modes. Instead this is now a bit mask. Why? What
it the legal combination of these bits?
More information about the webkit-reviews
mailing list