[webkit-reviews] review granted: [Bug 82056] Use enumeration for CSS parser mode : [Attachment 133516] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 82056: Use enumeration for CSS parser mode
https://bugs.webkit.org/show_bug.cgi?id=82056

Attachment 133516: Patch
https://bugs.webkit.org/attachment.cgi?id=133516&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133516&action=review


> Source/WebCore/css/CSSParser.cpp:1339
> +    if (m_cssParserMode & CSSStrictMode || inShorthand())

Maybe we should add isStrict() helper member function?

> Source/WebCore/css/CSSParser.cpp:2288
> -	       || (id >= CSSValueWebkitFocusRingColor && id <
CSSValueWebkitText && !m_strict)) {
> +	       || (id >= CSSValueWebkitFocusRingColor && id <
CSSValueWebkitText && m_cssParserMode & CSSQuirksMode)) {

Add isQuirksMode() helper function?

> Source/WebCore/css/CSSParser.cpp:9083
> -	  
rule->styleRule()->setProperties(StylePropertySet::create(m_parsedProperties.da
ta(), m_parsedProperties.size(), m_strict));
> +	  
rule->styleRule()->setProperties(StylePropertySet::create(m_parsedProperties.da
ta(), m_parsedProperties.size(), m_cssParserMode & CSSStrictMode));

Do you plan to change the argument of StylePropertySet::create as a follow up?