[webkit-reviews] review denied: [Bug 13624] REGRESSION: can select text of an input button : [Attachment 133514] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Parag Radke <parag at motorola.com>'s
request for review:
Bug 13624: REGRESSION: can select text of an input button
https://bugs.webkit.org/show_bug.cgi?id=13624

Attachment 133514: Updated patch
https://bugs.webkit.org/attachment.cgi?id=133514&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133514&action=review


> Source/WebCore/rendering/RenderButton.cpp:66
> +    if (node())
> +	   return node()->isContentEditable();
> +
> +    return false;

Ugh... this is a render object. You should be calling rendererIsEditable
instead. r- because isContentEditable can trigger style recalc.
It's also better to write this as return node() &&
node()->rendererIsEditable().

> Source/WebCore/rendering/RenderButton.h:43
> +    virtual bool canBeSelectionLeaf() const;

Please use OVERRIDE macro :)

> Source/WebCore/rendering/RenderTextFragment.cpp:68
> +    if (node())
> +	   return node()->isContentEditable();
> +	   
> +    return false;

Ditto.

> Source/WebCore/rendering/RenderTextFragment.h:42
> +    virtual bool canBeSelectionLeaf() const;

OVERRIDE.