[webkit-reviews] review granted: [Bug 81947] Web Inspector: breakpoints should be disabled while live editing JavaScript. : [Attachment 133464] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 81947: Web Inspector: breakpoints should be disabled while live editing
JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=81947

Attachment 133464: Patch
https://bugs.webkit.org/attachment.cgi?id=133464&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133464&action=review


> Source/WebCore/ChangeLog:11
> +	   undo/redo wrapper and better detection of the noop opterations.

opterations?

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:355
> +	   if (this._isDirty)

Shouldn't we also mute context menu?