[webkit-reviews] review denied: [Bug 80030] [GObject bindings] Supplemental interfaces are not disabled with the "Conditional" attribute : [Attachment 133485] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 23 10:23:50 PDT 2012
Xan Lopez <xan.lopez at gmail.com> has denied review:
Bug 80030: [GObject bindings] Supplemental interfaces are not disabled with the
"Conditional" attribute
https://bugs.webkit.org/show_bug.cgi?id=80030
Attachment 133485: Patch
https://bugs.webkit.org/attachment.cgi?id=133485&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133485&action=review
This looks generally OK, but all the changes in the geolocation policy decision
code seem pretty much unrelated? I think they should go in a different bug &
patch, this is complicated enough to review as it is :) There also seems a
couple of simple to fix style issues in the generated code that trigger
warnings.
> Source/WebCore/ChangeLog:18
> + but the root conditional feature is.
Yeah, this definitely makes sense.
> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1081
> + push(@cBody, " return NULL;\n");
NULL here?
> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1094
> push(@cBody, " return NULL;\n");
And also here I suppose.
> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1231
> "core-object", coreObject,
NULL));
We might as well fix this double space while we are at it.
More information about the webkit-reviews
mailing list